Chromium Main Console
Legend: | Passed | Failed | Running | Exception |
[v8][api] Don't use v8::Object::SetAccessor() in gin tests
... and use SetNativeDataProperty() instead. SetAccessor() will be
deprecated soon.
Bug: 336325111
Change-Id: I299a2aedc99cefbf94e40c0cc90dadcaaf2ea70a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5476928
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291309}
Revert "ChromeOS Settings WebUI shows AuthPanel based on FF state"
This reverts commit 80582a30ec99e1d01a6ae67215f451c7a9e262b7.
Reason for revert: Causing volteer RELEASE_LKGM to fail for the
last 10 days:
https://ci.chromium.org/ui/p/chrome/builders/ci/chromeos-volteer-chrome-skylab?limit=200
Original change's description:
> ChromeOS Settings WebUI shows AuthPanel based on FF state
>
> Bug: b:271248452
> Change-Id: Iab016f6bcf822fc245e452237af7cb5efb111e6e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5366925
> Commit-Queue: Elie Maamari <emaamari@google.com>
> Reviewed-by: Wes Okuhara <wesokuhara@google.com>
> Cr-Commit-Position: refs/heads/main@{#1286406}
Bug: b:336385314
Change-Id: Icf13a9cd45dea1d1ce33727a064fd9a5c3e92d22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5474550
Commit-Queue: Michael Wojcicka <mwoj@google.com>
Reviewed-by: Wes Okuhara <wesokuhara@google.com>
Cr-Commit-Position: refs/heads/main@{#1291308}
Roll devtools-internal from 2d280bcd2e70 to 27f7e1e187f5 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/2d280bcd2e70..27f7e1e187f5
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/002df0c83865ec766c9e4059aaef91bc3e95db4a..5d81c5e197ae203c6940a9e0daf649d3797c9379
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com,liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: devtools-waterfall-sheriff-onduty@rotations.google.com
Change-Id: I5ab595efed867b6f061f84b2681dfa5169ce3700
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5476021
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291307}
Roll ios_internal from 3227062ce268 to 6a9eeaf3ce7f
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/3227062ce268..6a9eeaf3ce7f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,djean@google.com,ewannpv@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I35e7ef5e50ea5bb38277923676a6b9ed70879685
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5476100
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291306}
Reland "Android: Switch from asan_device_setup.py -> wrap.sh (requires O MR1)"
This reverts commit f3e1cfa3aa4ff3b0527f89693dc7c812d2a63f0a.
Reason for reland: Disabling Android lint when ASAN is enabled
Original change's description:
> Revert "Android: Switch from asan_device_setup.py -> wrap.sh (requires O MR1)"
>
> This reverts commit 84403489f35c53871456c34db51ffa150add33de.
>
> Reason for revert: Lint errors breaking ASAN compiles
>
> Original change's description:
> > Android: Switch from asan_device_setup.py -> wrap.sh (requires O MR1)
> >
> > This bumps the minSdkVersion required for running with is_asan=true to
> > O MR1, but the new mechanism does not require modifying any global state
> > on the device, so is much safer to use.
> >
> > Removes the --tool arg from test_runner.py, since the test runner no
> > longer needs to do anything extra for asan to work. The one thing it
> > does still require is to increase the timeout scale, so this changes to
> > using --timeout-scale directly instead.
> >
> > Also changes ScalableTimeout to being set via instrumentation argument
> > instead of reading its value from /data/local/tmp.
> >
> > And removes @TimeoutScale annotation, which was used only by a single
> > test in order to extend the timeout of @Manual tests.
> >
> > Finally, this extends the timeout for @Manual tests from 10 hours to
> > 1000 hours... because why would we want a timeout on a @Manual test?
> >
> > Bug: 333709824
> > Change-Id: I4461f05df9143695a8d060f40d9159b45d297cdd
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5473125
> > Reviewed-by: Haiyang Pan <hypan@google.com>
> > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1290797}
>
> Bug: 333709824, 336378247
> Change-Id: I9cb676d547c63e5d1dff4f583ff9886d4fe4b068
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5475102
> Auto-Submit: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1291018}
Bug: 333709824, 336378247
Change-Id: If30b954c371a83aa5a30882a54d13f23b2224b7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5473570
Commit-Queue: Haiyang Pan <hypan@google.com>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/main@{#1291305}
[lensoverlay] Allow lens overlay to persist between tab switches.
Change-Id: Ifc1a39f6a84d6057ceec3088037e34d91909e407
Bug: b:333427057
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464431
Commit-Queue: Juan Mojica <juanmojica@google.com>
Reviewed-by: Duncan Mercer <mercerd@google.com>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291304}
Swap out asvitkine for manukh for Omnibox histogram owners.
Also add chrome-search@google.com.
Change-Id: I6fc31a967dc907e0945f8cda98c1bde1378a6dc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472664
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291303}
Switch SafeBrowsing.Settings.UserAction histogram to variants.
Change-Id: I2854e413bb3b1ede0fe664607b3941ef7a48b104
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5473028
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291302}
Revert "infra: Move ios-simulator bot to CQ experiment"
This reverts commit e930ac833cb6f0951fb2eaf29975ff9dfa9add12.
Reason for revert: cleandead was rolled back. https://crrev.com/c/5473538
I also cleaned Xcode named caches from all iOS bots. https://crbug.com/336382863#comment26
Original change's description:
> infra: Move ios-simulator bot to CQ experiment
>
> It's incorrectly failing a large number of builds:
> https://ci.chromium.org/ui/p/chromium/builders/try/ios-simulator/1912387/infra
>
> This removes it from the CQ until it's fixed.
>
> Bug: 336382863
> Change-Id: Ide39ebecd3c3eddbe9f9d78dba4ced418f38b48b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5473925
> Reviewed-by: Junji Watanabe <jwata@google.com>
> Commit-Queue: Junji Watanabe <jwata@google.com>
> Cr-Commit-Position: refs/heads/main@{#1291027}
Bug: 336382863
Change-Id: I4760b57e06de87a28c2d431ade791133466c2644
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5475063
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Stephanie Kim <kimstephanie@google.com>
Commit-Queue: Erik Staab <estaab@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291301}
[ios] Remove unused ContentSuggestionsAudience methods
Change-Id: I7472df183ae375cd8afb4802338fa0e7baf98672
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5474524
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Scott Yoder <scottyoder@google.com>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291300}
Roll Depot Tools from 401216ed9b72 to f8d1ff28d211 (1 revision)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/401216ed9b72..f8d1ff28d211
2024-04-23 msavigny@google.com Override reclient timeouts on windows.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,aravindvasudev@google.com,gavinmak@google.com,sokcevic@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ajp@google.com,aravindvasudev@google.com,gavinmak@google.com,sokcevic@chromium.org
Change-Id: Ib54952093794607e79794d4741f0e506a65c838c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5477207
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291299}
Reland "Reland "[DIPS] Better handle uncommitted navigations.""
This is a reland of commit 249705ac32e14d7c3653de4597cfbd2a28c23b68
Original change's description:
> Reland "[DIPS] Better handle uncommitted navigations."
>
> This is a reland of commit 6634c2892d4249eaa2432bedc1ea607e23df50c1
>
> The one change is a fix to
> DIPSBounceDetectorBrowserTest.NoContentSetCookie to remove flakiness.
>
> Original change's description:
> > [DIPS] Better handle uncommitted navigations.
> >
> > Treat the last URL visited as a redirect, not the final URL. Use the
> > last-committed URL as the final URL of the uncommitted chain, because
> > that's the page the user will end up on.
> >
> > Bug: 40279118
> > Change-Id: I3b62ec57c9f352d37477222d5c33eae7f218aca6
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5450446
> > Commit-Queue: Ryan Tarpine <rtarpine@chromium.org>
> > Reviewed-by: Anton Maliev <amaliev@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1287473}
>
> Bug: 40279118
> Change-Id: Ibbaa901a021b5e5dcd13d4cd2aad1b8c7de22dd0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5457953
> Reviewed-by: Anton Maliev <amaliev@chromium.org>
> Commit-Queue: Ryan Tarpine <rtarpine@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1288748}
Bug: 40279118, 336161248
Change-Id: I5809b53ff3c756ebaddee8071b2b5265dc035735
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5465387
Reviewed-by: Anton Maliev <amaliev@chromium.org>
Commit-Queue: Ryan Tarpine <rtarpine@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291298}
[A11y] Allow UA shadow doms to prune a11y subtrees with aria-hidden
Currently only used by <input type=file>.
However, having this change makes it easier to land the downstream
CL:5467030 that cleans up <select size=1> support.
Bug: none
Change-Id: I8ab983ed98fe1522ab44ae0e5cc4d4a862a7987b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5473096
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Mark Schillaci <mschillaci@google.com>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291297}
IWYU: missing include for usage of std::vector in noise.h
Bug: 41455655
Change-Id: I8b75671c173d833e79b8dbfc29a45678f48962e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5475087
Commit-Queue: José Dapena Paz <jdapena@igalia.com>
Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291296}
[PM] Refactor OnBeforeFoo and OnFoo observers 1/4
Updates the WorkerNodeImpl unit tests to track every observer method
that's called. This will simplify followup CL's that change WorkerNode
observers.
This series of patches tightens the semantics of PM node observers:
* Adding nodes or connections between nodes will have 2 observer
phases: OnBeforeFoo (before the new connections exist in the graph)
and OnFoo (after the new connections are created). These give
callers a last chance to iterate the graph without following the
new connections, and a first chance to iterate the graph with them.
* Removing nodes or connections will have only OnBeforeFoo (called
while the connection still exists) as a last chance to iterate the
graph with the old connections, since no new information would be
added by an OnFoo after the connections are deleted.
* When each observer is called the graph state will be consistent.
R=pmonette
Bug: 40930981
Change-Id: I251fe279bbc88c4ebd5528999b5e22251bcd8d72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5477108
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/main@{#1291295}
Update expected_bid to expected_bids in param comments.
... to match the function's parameter change.
Change-Id: I9cea43baeebd69c41d0a0613c51923aad29115b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472987
Commit-Queue: Qingxin Wu <qingxinwu@google.com>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291294}
Remove smcgruer@ from historic OWNERS files
These are all areas where I no longer have
enough context/knowledge to be an effective
OWNER, so removing myself from the files.
Bug: None
Change-Id: I32e200ad28b94dcfd2d3687d9cb90d273c0a739c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5476947
Reviewed-by: Weizhong Xia <weizhong@google.com>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291293}
PEPC/permission prompt new strings
Replaces existing strings and adds a few new strings.
Bug: 1462930
Fixed: 335834792
Change-Id: I6f7b6976632df54f53854c844006f3ddf92302f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5453579
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291292}
Roll Skia from a373bf46bffb to 7615d1ebbf1c (1 revision)
https://skia.googlesource.com/skia.git/+log/a373bf46bffb..7615d1ebbf1c
2024-04-23 brianosman@google.com Revert "Reland "Restore affine bitmap procs""
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jvanverth@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: jvanverth@google.com
Change-Id: I7e4bd86b148f8d6707cd76cd420d0cf086ea25c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5475741
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291291}
[A11y] Add more failures to a11y bot exceptions list
Bug: none
Change-Id: Ic1b65107dc9eeabef93c7affb5432d47096147db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5476847
Reviewed-by: Mark Schillaci <mschillaci@google.com>
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/main@{#1291290}
[DBSC] Implement CookieCraving for checking cookie presence
This adds a new class, CookieCraving, which subclasses CookieBase and
represents the requirement ("craving") for a matching real cookie (i.e.
CanonicalCookie instance).
It reuses code from CanonicalCookie, but it is conceptually different as
it does not represent a real instance of a cookie. Deviations from
CanonicalCookie logic are documented.
It will be used to implement the DBSC logic that decides whether to
defer a given request based on the presence or absence of a required
cookie.
Bug: 41495201
Change-Id: Iadef87d49e136d65e34efe076246c456f744fc66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463337
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291289}
Roll androidx from 97qGH6bsrI9G8hB0K... to kgxstkyFEP5qWXRI-...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/androidx-chromium
Please CC clank-build@google.com,clank-library-failures@google.com,wnwen@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel
Tbr: clank-library-failures@google.com
Change-Id: I1efac64a1aa21dc56a400f336139a84a69002f0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5475759
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291288}
[iOSKAUpgrade] Update font of manual fill cells' header title
This CL updates the font of the manual fill cells' header title to match
that of the chips when the Keyboard Accessory Upgrade feature is
enabled.
Before/After comparison when the KA Upgrade feature is disabled (there
should be no changes):
https://screenshot.googleplex.com/AjAhyhpTm79FMoE.png
Before/After comparison when the KA Upgrade feature is enabled:
https://screenshot.googleplex.com/ccLmqwBSQeRWXfY.png
Mocks: go/ios-keyboard-accessory-upgrade-mocks
Fixed: 336291476
Change-Id: Id4e118585e35082b1a484fca3ab0b04737e0a3bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472948
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Noémie St-Onge <noemies@google.com>
Cr-Commit-Position: refs/heads/main@{#1291287}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1713862697-2972fcc9b803216624cc741cb407a6e5ea838fbf-e3a02c7c17532090a8e188ddbcbcf2344986f0f7.profdata to chrome-win32-main-1713873578-08ba419a7142b856394065128bdcfabb44c6ae30-84072da101f658e760ecf93157948db2192a1d5f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I0b2da2f3efc4dbd1c6f723a48e3a9228ef3fbb07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5476017
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291286}
Roll V8 from 2bd5a47e1a3e to fd82d9a2134c (7 revisions)
https://chromium.googlesource.com/v8/v8.git/+log/2bd5a47e1a3e..fd82d9a2134c
2024-04-23 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 12.6.75
2024-04-23 victorgomes@chromium.org Reland "[maglev] Re-enable ReduceFunctionPrototypeApplyCallWithReceiver"
2024-04-23 leszeks@chromium.org Revert "[turboshaft][csa] Ship builtins compiled with Turboshaft"
2024-04-23 nicohartmann@chromium.org [turboshaft][csa] Ship builtins compiled with Turboshaft
2024-04-23 bikineev@chromium.org [heap] Introduce StickySpace and allocate on it for sticky mark-bits
2024-04-23 evih@chromium.org [fuzzer][memory64] Merge memop<> and atomic_op<>
2024-04-23 dmercadier@chromium.org [turboshaft] Maglev-to-ts: support Load/SetNamedGeneric
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-chromium-autoroll
Please CC liviurau@google.com,machenbach@google.com,v8-waterfall-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:dawn-linux-x64-deps-rel
Change-Id: I44bd362d9ee481a645db435412e2b5b38396d9ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5475680
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291285}
[iOS] Fix truncation on Payments Bottom Sheet
Truncation wasn't working properly on Payments Bottom Sheet because
TableViewDetailIconCell's setDetailText function ends up changing the
textLabel's number of lines. Setting the textLabel's properties after
the setDetailText call solves the issue.
Bug: 335727011
Change-Id: I81e03ab431f480e84c261a5792a9ce115036a3c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5473006
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291284}
Support font-variant-emoji shorthand parsing
Support parsing of `font-variant-emoji` values in `font-variant`
shorthand property, compare [0].
Reset `font-variant-emoji` to its initial value if `font` shorthand is
set and serialize `font` shorthand to an empty string if
`font-variant-emoji` is set, compare [1].
More info about `font-variant-emoji` implementation can be found in
design doc [2].
[0] https://www.w3.org/TR/css-fonts-4/#font-variant-prop
[1] https://drafts.csswg.org/css-fonts-4/#font-prop
[2] https://docs.google.com/document/d/1NyIKm0PnWUwX6j0smDwxDAPSUoiyBHPL95oH2lvjjpc/edit?usp=sharing
Bug: 40244183
Change-Id: Ib7adbf9146e6d4811080cb6f1084b38a2844c7da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464222
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Munira Tursunova <moonira@google.com>
Cr-Commit-Position: refs/heads/main@{#1291283}
Add use counters for layers with filters
Add use counters for Canvas2D Layers that use filters, and for each
alternative for declaring filters in beginLayer().
Bug: 1396372
Change-Id: I02461b9a6531373e5cf2b1e5ac23f1e14342b3dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5405317
Commit-Queue: Andres Ricardo Perez <andresrperez@chromium.org>
Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291282}
Kiosk: Fix missing browser window in Lacros
Lacros sends the 'app loaded' and 'app visible' events out of order.
This can cause the KioskLaunchController to never set the session state
to 'active', which kept all browser windows invisible.
This fix ensures an extra 'app loaded' event will be sent if the 'app
visible' event is received first.
Fixed: b/335158496
Change-Id: I635e0254e298cdbf934201696fdc8f2f505487b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472406
Reviewed-by: Edman Anjos <edman@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/main@{#1291281}
Automatic update from google3
Automatic update for 2024-04-23 UTC
Change-Id: I31b88f832f10d31f1ec38235ab19879ac700e8ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5476688
Commit-Queue: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Bot-Commit: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Cr-Commit-Position: refs/heads/main@{#1291280}
Revert "[Gardening] Disable flaky StickyKeysBrowserTest"
This reverts commit 60bd7fb6f5e1352a1a84203653cf683585491f98.
Reason for revert: Branded lacros fix landed in
crrev.com/c/5468470
Original change's description:
> [Gardening] Disable flaky StickyKeysBrowserTest
>
> Bug: 336342347
> AX-Relnotes: n/a
> Change-Id: I35180d863acd08e300d08d0561f0da40e6d36420
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472333
> Reviewed-by: Patrick Monette <pmonette@chromium.org>
> Commit-Queue: Muyao Xu <muyaoxu@google.com>
> Commit-Queue: Patrick Monette <pmonette@chromium.org>
> Auto-Submit: Muyao Xu <muyaoxu@google.com>
> Owners-Override: Muyao Xu <muyaoxu@google.com>
> Cr-Commit-Position: refs/heads/main@{#1290855}
Bug: 336342347
Change-Id: Ibb3753cfcebfcba833744be7f97839db1c82344d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472338
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Muyao Xu <muyaoxu@google.com>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291279}
Extend expiration of hisograms related to the 64-bit Clank/WebView work
Change-Id: Ibb3b6c6ae3cc5a9e3ea00ee494df7c9198400227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5473804
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Bartek Nowierski <bartekn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291278}
Add missing semicolons to mojo feature documentation
The example code is missing them.
Change-Id: Idfc7fc501b6be37fa7538af6d25a5a6a822a2bed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5477187
Commit-Queue: Alex Turner <alexmt@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Auto-Submit: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291277}
SidePanel: Migrate c/b/r/side_panel/reading_list to Lit, part 5 (last)
In this part
- checking in the .html.ts files
- removing the Polymer dependency, which enables stricter TS checks
- removing a few obsolete Polymer style imports in elements that have
already migrated to Lit.
- migrating a few CSS vars files dependencies to Lit.
- partially remove Polymer dependency in tests, by using
microtasksFinished(). iron-test-helpers/mock-interactions.js
dependency will be dealt with in the future.
With the changes above chrome://read-later.top-chrome/ no longer loads
Polymer at runtime.
Bug: 40943652
Change-Id: Ibe93f7c9bbc9a4bb10ccea716b671477ba0babe8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472440
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291276}
Updating trunk VERSION from 6436.0 to 6437.0
* This is an automated release commit.
* Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
Change-Id: I8a6cb8e8b3ef0f8a73781c6b36006dfeceaefb86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5477327
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291275}
[PEPC] Provide partial padding support to allow for common use case
Removal of 'padding' support from the permission element has removed
support for a common use case that used padding in conjunction with
'width: auto'. Since it is very difficult to provide a fixed width
for the permission element (as the text can change and is not under
the control of the site author), this CL provides a mechanism that
sets the width/height based on padding.
We don't want to simply support padding unchecked since it can be
used to push the text outside of the permission element area, and
creating a bounded expression is very difficult because 'calc-size'
is not supported for padding lengths.
Also do a quick cleanup of vertical-align.
Bug: 1462930
Fixed: 335835011
Change-Id: I19e6f9ff6fcd11073b1da0efaa68f743ea3886bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5458152
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291274}
Roll Chrome Lacros Amd64 Generic PGO Profile
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1713830503-72cb2f4bb4dd1dfef32be013ba38f6367b78925d-179675764a14f6d640ef7a04c7eb2d1f9d9fe43a.profdata to chrome-chromeos-amd64-generic-main-1713873578-7dff6303b17f42f2da4d35ec308e443928775f2a-84072da101f658e760ecf93157948db2192a1d5f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-lacros-amd64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I87b4a1f3f7588806d1ece8d4f696e7d84b64d801
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5475681
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291273}
[Android] Use espresso matchers to click first suggestion.
Change-Id: Ia5d9fe1daaf6cee3038591367b48e92bd03382ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472096
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Timofey Chudakov <tchudakov@google.com>
Cr-Commit-Position: refs/heads/main@{#1291272}
Inline some helpers in two_client_extension_settings_sync_test.cc
Change-Id: I1033bdc03dc31cc4808e236e208670c16d83d1ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5476348
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/main@{#1291271}
Fenced frames: Restore network revocation nonces when Network
Service crashes.
NetworkContext has a member `network_revocation_nonces_`, which is a
set of nonces whose network access is revoked. When NetworkService
crashes, it will destroy its NetworkContext.
When NetworkContext is recreated, `network_revocation_nonces_` must be
restored to the state before the crash. This is done using the copy of
nonces saved in StoragePartition. Otherwise, fenced frames that
previously have network disabled and got access to cross-site data,
will regain network access.
Bug: 41488151
Change-Id: If84d1b592b6c2500fa90439c5db7fe1ec6f60ca7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5440136
Reviewed-by: mmenke <mmenke@chromium.org>
Reviewed-by: Garrett Tanzer <gtanzer@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291270}
Roll clank/internal/apps from 9a53dcf680b0 to cd3becd640d6 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/9a53dcf680b0..cd3becd640d6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC bsazonov@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:332004713,chromium:334743133
Tbr: bsazonov@google.com
No-Try: true
Change-Id: I9fa3dc2a43ede7bac81e90422744a028dd009dfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5476022
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291269}
Make PlusProfile::facet a variant
Today, PlusProfile::facet is a std::string, which represents an eTLD+1.
Together with sync support, the semantics of the facet will be changed
to FacetURI (= web origin or Android package).
This CL prepares the code for this change, by changing the type of
PlusProfile::facet from std::string to
absl::variant<std::string, affiliations::FacetURI> and adapting the
production code. This builds on top of crrev.com/c/5471785.
Without sync support, the value continues to be a string, while with
sync support, the value is a FacetURI.
In particular,
- Inside webdata/ it is assumed that PlusProfile::facet contains an
affiliations::FacetURI.
- The sync bridge already filters invalid FacetURIs out.
- The PlusProfileSpecifics <-> PlusProfile conversion logic parses
the string from the proto to a FacetURI.
- PlusProfileTable stores the FacetURI::canonical_spec() and parses
this string back to a FacetURI when reading from the table.
No migration logic is needed, since the table is currently unused,
and even when the feature flag is explicitly enabled, data is
deleted on signout.
- Similarly, inside affiliations logic, it is assumed that the facet
contains a FacetURI.
- In PlusAddressHttpClient..
- GetAllPlusAddresses() (used for the polling logic) continues
treating the facet as eTLD+1, as this will be deprecated with sync
support.
- reserve/create branch based on the state of the sync feature.
- In PlusAddressService, logic branches based on the state of the sync
feature too.
This CL does not adapt most of the tests. Since the sync feature is
still disabled by default, tests can still assume that facets are
eTLD+1s. As such, this CL only adapts these tests code by adding
absl::get<std::string>(facet) calls, to make it compile. Once the
feature gets enabled by default, this will be changed. For most tests,
it shouldn't make a difference, since the tests rely on helpers like
test::CreatePlusProfile() and don't specifically care about facets.
Webdata and affiliation-related tests are explicitly changed, since
their code now assumes the FacetURI representation. There, the new
parameter to test::CreatePlusProfile() introduced by crrev.com/c/5471785
is utilized.
Bug: b/322147254
Change-Id: I60c6e78b77455719f464a646278a760b07ccdb53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5471724
Commit-Queue: Florian Leimgruber <fleimgruber@google.com>
Reviewed-by: Norge Vizcay <vizcay@google.com>
Reviewed-by: Jan Keitel <jkeitel@google.com>
Cr-Commit-Position: refs/heads/main@{#1291268}
Fullscreen: Encapsulate ExclusiveAccessBubble params in a struct
Add ExclusiveAccessBubbleParams struct for creation and updating.
Update names and comments for simplicity and clarity.
Remove undefined exclusive_access_bubble helper functions.
Bug: None
Change-Id: I37043a2a2b0909c660f00693fe6dd6ba6d3701de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5468588
Commit-Queue: Lily Chen <chlily@chromium.org>
Auto-Submit: Mike Wasserman <msw@chromium.org>
Reviewed-by: Irina Fedorova <irfedorova@google.com>
Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291267}
[Android][3PPWM] Restart after toggle-change
This CL adds the wiring to restart and does so immediately. Next step
is to show a message before doing so and reset the toggle if declined.
Feature Guard: AutofillVirtualViewStructureAndroid
Context: go/3ppwm-dd
Bug: 308551195
Change-Id: Iac25084a13f67e5d17987c282eabe490698a43c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5473072
Reviewed-by: Timofey Chudakov <tchudakov@google.com>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Andrey Zaytsev <andzaytsev@google.com>
Cr-Commit-Position: refs/heads/main@{#1291266}
IWYU: missing include for usage of int8_t in ink_brush_behavior.h
Bug: 41455655
Change-Id: Ibb1ca76cd7b1aa437d91060b5c83af15c3fb9ceb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5475207
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291265}
[ios] Refactor chrome_browser_state_client
This CL contains the following changes:
- chrome_browser_state_client was renamed to demographics_client
- GetCachedBrowserState() was added, this is needed to be sure that
future calls will continue to call the same browserState (if still
valid). This is needed to support multiple identities (note that a
similar solution is used in chrome/*, check bug comments for
additional details).
Note that with this change code is still run for only one loaded
browserState (differently from what was asked to do in the TODO),
in this way the code will be similar to what we have in chrome/*.
Fixed: 325255648
Change-Id: I11f061464ccd1ab3ef1d53c3582df407b9dfc5ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5471826
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Asami Doi <asamidoi@chromium.org>
Commit-Queue: Federica Germinario <fedegermi@google.com>
Cr-Commit-Position: refs/heads/main@{#1291264}
Roll NaCl from 0253008929d3 to 8b46870c2d4b (1 revision)
https://chromium.googlesource.com/native_client/src/native_client.git/+log/0253008929d3..8b46870c2d4b
2024-04-23 nathaniel@google.com Drop dynamic_annotations license
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/nacl-autoroll
Please CC fabiansommer@chromium.org,fabiansommer@google.com,mseaborn@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1282422,chromium:605605
Tbr: fabiansommer@chromium.org,mseaborn@chromium.org
Change-Id: I27b2f9a42dbc3e4312ff7bba05c34bcc91ee40ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5475755
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291263}
Testing config for field trial to optimize static animation properties
Bug: 336267855
Change-Id: I0afa02e6fa66f53fb1b84069e415699d6c6d1aca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5473084
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291262}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1713851933-ab1d222870cba6a0481466ec538bbe611e9c74fa-182bc25b0777695b2b4b5cc5663fcea2abaac2b0.profdata to chrome-linux-main-1713873578-48a0c0d0df863946e182190ac5d8e83c1f290df7-84072da101f658e760ecf93157948db2192a1d5f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I0d1a1d20e98d8eb2b1a620b5e6b04ff51829401a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5475756
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1291261}
[Cookies] Make Lax-allowing-unsafe behavior virtual
The Lax-allowing-unsafe (a.k.a. Lax+POST) behavior of CanonicalCookie
allows a cookie with SameSite unspecified (defaulting to Lax) to
actually be sent on cross-site requests with unsafe methods (POST, etc.)
within 2 minutes of their creation time (which doesn't usually happen
for a Lax cookie). This was introduced as a web compatibility measure
to avoid breakage from SameSite=Lax-by-default.
Since CanonicalCookie is now a subclass of CookieBase, and other
CookieBase subclasses will exist soon that may not want
Lax-allowing-unsafe behavior, this CL makes that behavior customizable
by the subclass.
The default behavior of CookieBase does NOT permit
Lax-allowing-unsafe; it is instead implemented by CanonicalCookie
overriding it. Lax-allowing-unsafe was intended to be a temporary
mitigation, and while there has not been much progress towards removing
it because the web platform still relies on it, we should default
towards not having it in the base class because that's the desired end
state.
Bug: 324405105
Change-Id: I69d647a043ce8683df0bf7a0b2a950242431101e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464071
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Steven Bingler <bingler@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291260}